[Lldb-commits] [lldb] r207449 - Address warnings in EmulateInstructionARM64

Ed Maste emaste at freebsd.org
Mon Apr 28 14:34:04 PDT 2014


Author: emaste
Date: Mon Apr 28 16:34:04 2014
New Revision: 207449

URL: http://llvm.org/viewvc/llvm-project?rev=207449&view=rev
Log:
Address warnings in EmulateInstructionARM64

- Remove default for switch which covers all enumeration values

- Remove unused functions
  LSL_C is left in the source under #if 0, as it may be needed in the
  future for emulating other instructions.

Differential Revision: http://reviews.llvm.org/D3528

Modified:
    lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
    lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h

Modified: lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp?rev=207449&r1=207448&r2=207449&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp (original)
+++ lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp Mon Apr 28 16:34:04 2014
@@ -58,14 +58,7 @@ NOT(uint64_t x)
     return ~x;
 }
 
-
-static inline int64_t
-SignExtend64(uint64_t x, uint32_t msbit) 
-{
-    return int64_t(x << (64 - msbit)) >> (64 - msbit);
-}
-
-
+#if 0
 // LSL_C() 
 // =======
 static inline uint64_t
@@ -76,6 +69,7 @@ LSL_C (uint64_t x, integer shift, bool &
     carry_out = ((1ull << (64-1)) >> (shift - 1)) != 0;
     return result;
 }
+#endif
 
 // LSL()
 // =====

Modified: lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h?rev=207449&r1=207448&r2=207449&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h (original)
+++ lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h Mon Apr 28 16:34:04 2014
@@ -46,9 +46,6 @@ public:
             case lldb_private::eInstructionTypePCModifying:
             case lldb_private::eInstructionTypeAll:
                 return false;
-                
-            default:
-                break;
         }
         return false;
     }





More information about the lldb-commits mailing list