[Lldb-commits] [PATCH] Address warnings in EmulateInstructionARM64

Greg Clayton gclayton at apple.com
Mon Apr 28 13:34:24 PDT 2014


Looks good.

On Apr 28, 2014, at 11:58 AM, Ed Maste <emaste at freebsd.org> wrote:

> Leave LSL_C in, hidden under #if 0, per Greg's request.
> This file is using llvm::SignExtend64 already, so no need to keep our own copy of that.
> 
> http://reviews.llvm.org/D3528
> 
> Files:
>  source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
>  source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
> 
> Index: source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
> ===================================================================
> --- source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
> +++ source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
> @@ -58,14 +58,7 @@
>     return ~x;
> }
> 
> -
> -static inline int64_t
> -SignExtend64(uint64_t x, uint32_t msbit) 
> -{
> -    return int64_t(x << (64 - msbit)) >> (64 - msbit);
> -}
> -
> -
> +#if 0
> // LSL_C() 
> // =======
> static inline uint64_t
> @@ -76,6 +69,7 @@
>     carry_out = ((1ull << (64-1)) >> (shift - 1)) != 0;
>     return result;
> }
> +#endif
> 
> // LSL()
> // =====
> Index: source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
> ===================================================================
> --- source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
> +++ source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
> @@ -46,9 +46,6 @@
>             case lldb_private::eInstructionTypePCModifying:
>             case lldb_private::eInstructionTypeAll:
>                 return false;
> -                
> -            default:
> -                break;
>         }
>         return false;
>     }
> <D3528.8893.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits




More information about the lldb-commits mailing list