[Lldb-commits] [PATCH] Address warnings in EmulateInstructionARM64

Ed Maste emaste at freebsd.org
Mon Apr 28 07:04:22 PDT 2014


- Remove default for switch which covers all enumeration values
- Remove unused functions

http://reviews.llvm.org/D3528

Files:
  source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
  source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h

Index: source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
===================================================================
--- source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
+++ source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
@@ -58,25 +58,6 @@
     return ~x;
 }
 
-
-static inline int64_t
-SignExtend64(uint64_t x, uint32_t msbit) 
-{
-    return int64_t(x << (64 - msbit)) >> (64 - msbit);
-}
-
-
-// LSL_C() 
-// =======
-static inline uint64_t
-LSL_C (uint64_t x, integer shift, bool &carry_out)
-{
-    assert (shift >= 0); 
-    uint64_t result = x << shift;
-    carry_out = ((1ull << (64-1)) >> (shift - 1)) != 0;
-    return result;
-}
-
 // LSL()
 // =====
 
Index: source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
===================================================================
--- source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
+++ source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
@@ -46,9 +46,6 @@
             case lldb_private::eInstructionTypePCModifying:
             case lldb_private::eInstructionTypeAll:
                 return false;
-                
-            default:
-                break;
         }
         return false;
     }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3528.8883.patch
Type: text/x-patch
Size: 1238 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140428/abf545d9/attachment.bin>


More information about the lldb-commits mailing list