[Lldb-commits] [lldb] r207148 - Fixed a flipped conditional when writing back the

Sean Callanan scallanan at apple.com
Thu Apr 24 14:43:04 PDT 2014


Author: spyffe
Date: Thu Apr 24 16:43:04 2014
New Revision: 207148

URL: http://llvm.org/viewvc/llvm-project?rev=207148&view=rev
Log:
Fixed a flipped conditional when writing back the
values of variables in the Materializer.

The Materializer should not write the variable
back if its new value is the *same* as the old
value, not if the new value is *different*.

<rdar://problem/16712205>

Modified:
    lldb/trunk/source/Expression/Materializer.cpp

Modified: lldb/trunk/source/Expression/Materializer.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/Materializer.cpp?rev=207148&r1=207147&r2=207148&view=diff
==============================================================================
--- lldb/trunk/source/Expression/Materializer.cpp (original)
+++ lldb/trunk/source/Expression/Materializer.cpp Thu Apr 24 16:43:04 2014
@@ -614,7 +614,7 @@ public:
             if (m_original_data)
             {
                 if ((data.GetByteSize() == m_original_data->GetByteSize()) &&
-                    memcmp(m_original_data->GetBytes(), data.GetDataStart(), data.GetByteSize()))
+                    !memcmp(m_original_data->GetBytes(), data.GetDataStart(), data.GetByteSize()))
                 {
                     actually_write = false;
                 }





More information about the lldb-commits mailing list