[Lldb-commits] [lldb] r206618 - Address hung tests in Linux.

[jingham at apple.com]

This is okay as a workaround, but I am not sure why Linux threads are being created in the state eStateSuspended.  That state is for what the user directs the thread to do (SBThread::Suspend() and SBThread::Resume() for instance.)  It seems weird that this should be starting out as suspended.

Jim

On Apr 18, 2014, at 10:01 AM, Todd Fiala <tfiala at google.com> wrote:

> Author: tfiala
> Date: Fri Apr 18 12:01:01 2014
> New Revision: 206618
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=206618&view=rev
> Log:
> Address hung tests in Linux.
> 
> Follow-up patch coming to address test failures exposed by this change.
> 
> 
> Modified:
>    lldb/trunk/source/Plugins/Process/POSIX/POSIXThread.cpp
> 
> Modified: lldb/trunk/source/Plugins/Process/POSIX/POSIXThread.cpp
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/POSIX/POSIXThread.cpp?rev=206618&r1=206617&r2=206618&view=diff
> ==============================================================================
> --- lldb/trunk/source/Plugins/Process/POSIX/POSIXThread.cpp (original)
> +++ lldb/trunk/source/Plugins/Process/POSIX/POSIXThread.cpp Fri Apr 18 12:01:01 2014
> @@ -110,7 +110,7 @@ POSIXThread::RefreshStateAfterStop()
>         GetRegisterContext()->InvalidateIfNeeded (force);
>     }
>     // FIXME: This should probably happen somewhere else.
> -    SetResumeState(eStateRunning);
> +    SetResumeState(eStateRunning, true);
>     Log *log (ProcessPOSIXLog::GetLogIfAllCategoriesSet (POSIX_LOG_THREAD));
>     if (log)
>         log->Printf ("POSIXThread::%s (tid = %" PRIi64 ") setting thread resume state to running", __FUNCTION__, GetID());
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits