[Lldb-commits] [lldb] r205978 - <rdar://problem/16540961>

[Enrico Granata]

Author: enrico
Date: Thu Apr 10 13:17:30 2014
New Revision: 205978

URL: http://llvm.org/viewvc/llvm-project?rev=205978&view=rev
Log:
<rdar://problem/16540961>

The "unexpected value" message only matters to me, but is bound to make the experience more confusing for people when some uninitialized memory looks like an NSNumber and then can't be formatted properly, and that error comes out in the UI

Just drop the error message entirely - nobody but me cares


Modified:
    lldb/trunk/source/DataFormatters/Cocoa.cpp

Modified: lldb/trunk/source/DataFormatters/Cocoa.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/DataFormatters/Cocoa.cpp?rev=205978&r1=205977&r2=205978&view=diff
==============================================================================
--- lldb/trunk/source/DataFormatters/Cocoa.cpp (original)
+++ lldb/trunk/source/DataFormatters/Cocoa.cpp Thu Apr 10 13:17:30 2014
@@ -342,8 +342,7 @@ lldb_private::formatters::NSNumberSummar
                     stream.Printf("(long)%" PRId64,value);
                     break;
                 default:
-                    stream.Printf("unexpected value:(info=%" PRIu64 ", value=%" PRIu64,i_bits,value);
-                    break;
+                    return false;
             }
             return true;
         }
@@ -402,8 +401,7 @@ lldb_private::formatters::NSNumberSummar
                     break;
                 }
                 default:
-                    stream.Printf("unexpected value: dt=%d",data_type);
-                    break;
+                    return false;
             }
             return true;
         }