[Lldb-commits] [lldb] r204747 - Fixed up intermittently failing tests to skip on Linux.

[Todd Fiala]

Author: tfiala
Date: Tue Mar 25 13:55:48 2014
New Revision: 204747

URL: http://llvm.org/viewvc/llvm-project?rev=204747&view=rev
Log:
Fixed up intermittently failing tests to skip on Linux.

Also added 'import sys' on some tests that are using non-standard
unittest2.skipUnless blocks with code that is intended to do things
that we have more specializes @* attributes for.  These skip
conditions were failing to execute due to missing import, causing
darwin-only tests to run on Linux regardless.  Will file a bug for
that separately.

Modified:
    lldb/trunk/test/expression_command/call-restarts/TestCallThatRestarts.py
    lldb/trunk/test/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py
    lldb/trunk/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py
    lldb/trunk/test/macosx/add-dsym/TestAddDsymMidExecutionCommand.py

Modified: lldb/trunk/test/expression_command/call-restarts/TestCallThatRestarts.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/expression_command/call-restarts/TestCallThatRestarts.py?rev=204747&r1=204746&r2=204747&view=diff
==============================================================================
--- lldb/trunk/test/expression_command/call-restarts/TestCallThatRestarts.py (original)
+++ lldb/trunk/test/expression_command/call-restarts/TestCallThatRestarts.py Tue Mar 25 13:55:48 2014
@@ -27,6 +27,7 @@ class ExprCommandThatRestartsTestCase(Te
         self.call_function()
 
     @dwarf_test
+    @skipIfLinux # llvm.org/pr19246: intermittent failure
     def test_with_dwarf(self):
         """Test calling std::String member function."""
         self.buildDwarf()

Modified: lldb/trunk/test/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py?rev=204747&r1=204746&r2=204747&view=diff
==============================================================================
--- lldb/trunk/test/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py (original)
+++ lldb/trunk/test/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py Tue Mar 25 13:55:48 2014
@@ -3,6 +3,7 @@
 import os, time
 import unittest2
 import lldb, lldbutil
+import sys
 from lldbtest import *
 
 class CrashingRecursiveInferiorTestCase(TestBase):
@@ -66,6 +67,7 @@ class CrashingRecursiveInferiorTestCase(
         self.recursive_inferior_crashing_step_after_break()
 
     @skipIfFreeBSD # llvm.org/pr16684
+    @expectedFailureLinux('llvm.org/pr16684')
     def test_recursive_inferior_crashing_step_after_break_dwarf(self):
         """Test that lldb functions correctly after stepping through a crash."""
         self.buildDwarf()
@@ -78,7 +80,7 @@ class CrashingRecursiveInferiorTestCase(
         self.recursive_inferior_crashing_expr_step_expr()
 
     @expectedFailureFreeBSD('llvm.org/pr15989') # Couldn't allocate space for the stack frame
-    @expectedFailureLinux # llvm.org/pr15989 - Couldn't allocate space for the stack frame
+    @expectedFailureLinux('llvm.org/pr15989') # Couldn't allocate space for the stack frame
     def test_recursive_inferior_crashing_expr_step_and_expr_dwarf(self):
         """Test that lldb expressions work before and after stepping after a crash."""
         self.buildDwarf()

Modified: lldb/trunk/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py?rev=204747&r1=204746&r2=204747&view=diff
==============================================================================
--- lldb/trunk/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py (original)
+++ lldb/trunk/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py Tue Mar 25 13:55:48 2014
@@ -6,6 +6,7 @@ import os
 import re
 import unittest2
 import lldb, lldbutil
+import sys
 from lldbtest import *
 
 class ReturnValueTestCase(TestBase):
@@ -40,6 +41,7 @@ class ReturnValueTestCase(TestBase):
 
     @python_api_test
     @dwarf_test
+    @skipIfLinux # intermittent failure - llvm.org/pr19247
     def test_step_over_with_dwarf_python(self):
         """Test stepping over using avoid-no-debug with dwarf."""
         self.buildDwarf()
@@ -57,6 +59,7 @@ class ReturnValueTestCase(TestBase):
 
     @python_api_test
     @dwarf_test
+    @skipIfLinux # intermittent failure - llvm.org/pr19247
     def test_step_in_with_dwarf_python(self):
         """Test stepping in using avoid-no-debug with dwarf."""
         self.buildDwarf()

Modified: lldb/trunk/test/macosx/add-dsym/TestAddDsymMidExecutionCommand.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/macosx/add-dsym/TestAddDsymMidExecutionCommand.py?rev=204747&r1=204746&r2=204747&view=diff
==============================================================================
--- lldb/trunk/test/macosx/add-dsym/TestAddDsymMidExecutionCommand.py (original)
+++ lldb/trunk/test/macosx/add-dsym/TestAddDsymMidExecutionCommand.py Tue Mar 25 13:55:48 2014
@@ -4,6 +4,7 @@ import os, time
 import unittest2
 import lldb
 import pexpect
+import sys
 from lldbtest import *
 
 @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")