[Lldb-commits] [lldb] r204545 - Cleanup some dead assignements reported by scan-build
Arnaud A. de Grandmaison
arnaud.adegm at gmail.com
Sat Mar 22 13:23:26 PDT 2014
Author: aadg
Date: Sat Mar 22 15:23:26 2014
New Revision: 204545
URL: http://llvm.org/viewvc/llvm-project?rev=204545&view=rev
Log:
Cleanup some dead assignements reported by scan-build
No functionnal change.
Modified:
lldb/trunk/source/Commands/CommandObjectExpression.cpp
lldb/trunk/source/Commands/CommandObjectTarget.cpp
lldb/trunk/source/Core/Module.cpp
lldb/trunk/source/Expression/IRForTarget.cpp
lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
lldb/trunk/source/Target/StopInfo.cpp
Modified: lldb/trunk/source/Commands/CommandObjectExpression.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectExpression.cpp?rev=204545&r1=204544&r2=204545&view=diff
==============================================================================
--- lldb/trunk/source/Commands/CommandObjectExpression.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectExpression.cpp Sat Mar 22 15:23:26 2014
@@ -277,8 +277,6 @@ CommandObjectExpression::EvaluateExpress
{
lldb::ValueObjectSP result_valobj_sp;
- ExecutionResults exe_results;
-
bool keep_in_memory = true;
EvaluateExpressionOptions options;
@@ -294,11 +292,9 @@ CommandObjectExpression::EvaluateExpress
options.SetTimeoutUsec(m_command_options.timeout);
else
options.SetTimeoutUsec(0);
-
- exe_results = target->EvaluateExpression (expr,
- exe_ctx.GetFramePtr(),
- result_valobj_sp,
- options);
+
+ target->EvaluateExpression(expr, exe_ctx.GetFramePtr(),
+ result_valobj_sp, options);
if (result_valobj_sp)
{
Modified: lldb/trunk/source/Commands/CommandObjectTarget.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectTarget.cpp?rev=204545&r1=204544&r2=204545&view=diff
==============================================================================
--- lldb/trunk/source/Commands/CommandObjectTarget.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectTarget.cpp Sat Mar 22 15:23:26 2014
@@ -2707,8 +2707,6 @@ protected:
}
else
{
- flush = true;
-
StreamString strm;
module_spec.GetUUID().Dump (&strm);
if (module_spec.GetFileSpec())
Modified: lldb/trunk/source/Core/Module.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/Module.cpp?rev=204545&r1=204544&r2=204545&view=diff
==============================================================================
--- lldb/trunk/source/Core/Module.cpp (original)
+++ lldb/trunk/source/Core/Module.cpp Sat Mar 22 15:23:26 2014
@@ -959,7 +959,7 @@ Module::FindTypes (const SymbolContext&
{
// The "type_name_cstr" will have been modified if we have a valid type class
// prefix (like "struct", "class", "union", "typedef" etc).
- num_matches = FindTypes_Impl(sc, ConstString(type_name_cstr), NULL, append, max_matches, types);
+ FindTypes_Impl(sc, ConstString(type_name_cstr), NULL, append, max_matches, types);
types.RemoveMismatchedTypes (type_class);
num_matches = types.GetSize();
}
Modified: lldb/trunk/source/Expression/IRForTarget.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/IRForTarget.cpp?rev=204545&r1=204544&r2=204545&view=diff
==============================================================================
--- lldb/trunk/source/Expression/IRForTarget.cpp (original)
+++ lldb/trunk/source/Expression/IRForTarget.cpp Sat Mar 22 15:23:26 2014
@@ -1993,7 +1993,6 @@ IRForTarget::ReplaceStaticLiterals (llvm
const size_t mask = (align - 1);
uint64_t aligned_offset = (offset + mask) & ~mask;
m_data_allocator.GetStream().PutNHex8(aligned_offset - offset, 0);
- offset = aligned_offset;
m_data_allocator.GetStream().Write(data.GetBytes(), operand_data_size);
Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp?rev=204545&r1=204544&r2=204545&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Sat Mar 22 15:23:26 2014
@@ -1357,7 +1357,6 @@ ObjectFileELF::ParseSymbolTable(Symtab *
user_id_t strtab_id = symtab_hdr->sh_link + 1;
Section *strtab = section_list->FindSectionByID(strtab_id).get();
- unsigned num_symbols = 0;
if (symtab && strtab)
{
assert (symtab->GetObjectFile() == this);
@@ -1370,13 +1369,12 @@ ObjectFileELF::ParseSymbolTable(Symtab *
{
size_t num_symbols = symtab_data.GetByteSize() / symtab_hdr->sh_entsize;
- num_symbols = ParseSymbols(symbol_table, start_id,
- section_list, num_symbols,
- symtab_data, strtab_data);
+ return ParseSymbols(symbol_table, start_id, section_list,
+ num_symbols, symtab_data, strtab_data);
}
}
- return num_symbols;
+ return 0;
}
size_t
Modified: lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp?rev=204545&r1=204544&r2=204545&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp Sat Mar 22 15:23:26 2014
@@ -232,7 +232,6 @@ ObjectFilePECOFF::SetLoadAddress(Target
}
}
changed = num_loaded_sections > 0;
- return num_loaded_sections > 0;
}
}
return changed;
Modified: lldb/trunk/source/Target/StopInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StopInfo.cpp?rev=204545&r1=204544&r2=204545&view=diff
==============================================================================
--- lldb/trunk/source/Target/StopInfo.cpp (original)
+++ lldb/trunk/source/Target/StopInfo.cpp Sat Mar 22 15:23:26 2014
@@ -452,8 +452,6 @@ protected:
error_sp->PutCString (err_str);
error_sp->EOL();
error_sp->Flush();
- // If the condition fails to be parsed or run, we should stop.
- condition_says_stop = true;
}
else
{
More information about the lldb-commits
mailing list