[Lldb-commits] Fwd: [PATCH] Remove use of broken DEBUGSERVER_VERSION_NUM.

Todd Fiala tfiala at google.com
Thu Mar 13 11:36:30 PDT 2014


tfiala-macbookpro:lldb tfiala$ EDITOR=emacs svn commit
Sending        tools/debugserver/source/CMakeLists.txt
Sending        tools/debugserver/source/RNBRemote.cpp
Sending        tools/debugserver/source/debugserver.cpp
Transmitting file data ...
Committed revision 203828.


On Thu, Mar 13, 2014 at 10:39 AM, Todd Fiala <tfiala at google.com> wrote:

> Hey Kuba - I'll get through all your outstanding patches today (the 4 from
> yesterday and this one here).
>
>
> On Thu, Mar 13, 2014 at 5:47 AM, Kuba Ober <kuba at mareimbrium.org> wrote:
>
>> Please commit. Thanks, Kuba
>>
>> > From: Greg Clayton <gclayton at apple.com>
>> > Subject: Re: [Lldb-commits] [PATCH] Remove use of broken
>> DEBUGSERVER_VERSION_NUM.
>> > Date: March 12, 2014 at 12:50:22 PM EDT
>> > To: Kuba Ober <kuba at mareimbrium.org>
>> > Cc: lldb-commits at cs.uiuc.edu
>> >
>> > Looks good.
>> >
>> > On Mar 11, 2014, at 2:49 PM, Kuba Ober <kuba at mareimbrium.org> wrote:
>> >
>> >> Since lldb version doesn’t have to be a valid floating point literal,
>> like x.y.z,
>> >> the uses of DEBUGSERVER_VERSION_NUM are invalid and have to be removed.
>> >>
>> >> Cheers, Kuba Ober
>> >>
>> >>
>> <debugserver_version_num.patch>_______________________________________________
>> >> lldb-commits mailing list
>> >> lldb-commits at cs.uiuc.edu
>> >> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>> >
>>
>>
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>
>
>
>
> --
> Todd Fiala | Software Engineer |  tfiala at google.com |  650-943-3180
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140313/b4ada722/attachment.html>


More information about the lldb-commits mailing list