[Lldb-commits] [lldb] r203107 - Fix Windows build break introduced in r203035.

Ed Maste emaste at freebsd.org
Mon Mar 10 13:44:37 PDT 2014


Seems fine to me as well, assuming it's actually "svn mv" when you go
to commit.  If it compiles on Linux it should on FreeBSD as well, or
will be trivially fixed.

As an aside, note that the division of code between the POSIX and
FreeBSD/Linux classes isn't quite correct; in some cases identical or
nearly-identical code exists in both the FreeBSD and Linux classes,
and in other cases code in ProcessPOSIX is actually Linux specific.
It might be a good opportunity for us to clean some of this up if
you're going to introduce base classes for Windows and POSIX.

On 10 March 2014 14:12, Greg Clayton <gclayton at apple.com> wrote:
> Looks fine.
>
> On Mar 10, 2014, at 9:16 AM, Virgile Bello <virgile.bello at gmail.com> wrote:
>
>> Small update: looks like it compiles fine on Linux.
>> Let me know if I should commit.



More information about the lldb-commits mailing list