[Lldb-commits] [PATCH] LLDB Python API support on Windows (ported the SWIG wrapper shell scripts to Python)

[Ed Maste]

================
Comment at: scripts/Python/buildSwigPython.py:1
@@ +1,2 @@
+""" Python SWIG wrapper creation script Windows/LINUX/OSX platform
+
----------------
Missing FreeBSD here; probably best to just not list platforms at all.
(Same comment applies to several files)

================
Comment at: scripts/Python/buildSwigPython.py:9
@@ +8,3 @@
+					
+	Environment:	OS:			Windows Vista or newer, LINUX, OSX.
+					IDE: 	    Visual Studio 2013 Plugin Python Tools (PTVS)
----------------
Same comment as above, and "IDE" on the next line seems odd -- presumably PTVS isn't needed on non-Windows platforms :)

(Same comment applies to several files)

================
Comment at: scripts/Python/finish-swig-Python-LLDB.sh:159
@@ -158,3 +158,3 @@
         ln -s "../../../LLDB" _lldb.so
-    else
+	else
         ln -s "../../../liblldb${SOEXT}" _lldb.so
----------------
accidental whitespace change?

================
Comment at: scripts/Python/finishSwigPythonLLDB.py:38
@@ +37,3 @@
+
+	Copyright:		None.
+	--------------------------------------------------------------------------
----------------
Recommend putting in the standard copyright & license notice instead

================
Comment at: scripts/utilsDebug.py:134
@@ +133,1 @@
+	
\ No newline at end of file

----------------
whitespace issue

================
Comment at: source/Interpreter/ScriptInterpreterPython.cpp:704
@@ -701,1 +703,3 @@
+namespace lldb_private
 {
+    class IOHandlerPythonInterpreter :
----------------
it's too bad that phabricator is confused by the indentation; is the only change the addition of the namespace?


http://llvm-reviews.chandlerc.com/D2980