[Lldb-commits] [PATCH] [lldb] Fix Darwin build broken by addition of JITLoaderGDB

[Greg Clayton]

We are building fine in Darwin with the Xcode build. The issue is most likely in cmake or make builds where a #include path is not fully specifying a path to the file in question. Nothing in ProcessELFCore or JITLoaderGDB should require ProcessMonitor.h:

The only current accesses to ProcessMonitor.h are in the following files:

% ack 'ProcessMonitor\.h'
Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
25:#include "ProcessMonitor.h"

Plugins/Process/FreeBSD/ProcessMonitor.cpp
36:#include "ProcessMonitor.h"

Plugins/Process/FreeBSD/ProcessMonitor.h
1://===-- ProcessMonitor.h -------------------------------------- -*- C++ -*-===//

Plugins/Process/Linux/ProcessLinux.cpp
25:#include "ProcessMonitor.h"

Plugins/Process/Linux/ProcessMonitor.cpp
39:#include "ProcessMonitor.h"

Plugins/Process/Linux/ProcessMonitor.h
1://===-- ProcessMonitor.h -------------------------------------- -*- C++ -*-===//

Plugins/Process/POSIX/POSIXThread.cpp
31:#include "ProcessMonitor.h"

Plugins/Process/POSIX/ProcessPOSIX.cpp
31:#include "ProcessMonitor.h"

Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_mips64.cpp
16:#include "ProcessMonitor.h"

Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_x86.cpp
15:#include "ProcessMonitor.h"


None of these files should be being built for native Darwin builds. If they are, fix the make files or make lists.

Greg

On Mar 10, 2014, at 9:40 AM, Jevin Sweval <jevinsweval at gmail.com> wrote:

> This ifdefs out calls to
> {JITLoaderGDB,ProcessorElfCore}::{Initialize,Terminate} when building
> for Apple hosts. I tried to instead build and link these libraries but
> I ran into an issue where Darwin doesn't have ProcessMonitor.h. I
> assume Windows hosts will be a similar situation? If so, the patch
> should be updated to reflect that.
> 
> Thanks,
> Jevin
> <LLDB_disable_JITLoaderGDB_on_darwin.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits