[Lldb-commits] [PATCH] Update LLDB for LLVM iterator change in r203364

Chandler Carruth chandlerc at gmail.com
Mon Mar 10 09:56:31 PDT 2014



================
Comment at: source/Expression/IRForTarget.cpp:362
@@ -365,3 +361,3 @@
 
-            for (auto u = fun->use_begin(), e = fun->use_end(); u != e; ++u) {
+            for (auto u = fun->user_begin(), e = fun->user_end(); u != e; ++u) {
                 if (auto call = dyn_cast<CallInst>(*u)) {
----------------
Why not range-based? This one satisfies the requirements.

================
Comment at: source/Expression/IRForTarget.cpp:1653
@@ -1658,3 +1652,3 @@
     
-    if (global_variable->use_begin() == global_variable->use_end())
+    if (global_variable->user_begin() == global_variable->user_end())
         return false;
----------------
This is cleaner:

  global_variable->use_empty()


http://llvm-reviews.chandlerc.com/D3030



More information about the lldb-commits mailing list