[Lldb-commits] [PATCH] Link libedit, libcurses, and libpanel on Darwin autoconf builds

[Todd Fiala]

Hey Jevin,

I got this running on my end.  I slightly tweaked the header handling and
moved the missing include to a preprocessor flag.

I've attached the fix that builds and runs on my end.  If you are not able
to check it in, I'd be happy to.

Let me know either way.

Sincerely,
Todd Fiala


On Fri, Feb 28, 2014 at 12:13 PM, Jevin Sweval <jevinsweval at gmail.com>wrote:

> On Fri, Feb 28, 2014 at 1:58 PM, Todd Fiala <tfiala at google.com> wrote:
> >
> > Hey Jevin,
> >
> > FWIW I tried this on my MBP at top of tree.  I am getting this error
> before hitting your patch's fix:
> >
> > llvm[5]: Compiling AppleGetQueuesHandler.cpp for Debug+Asserts build
> >
> /Users/tfiala/lldb/svn/llvm/tools/lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.cpp:16:10:
> fatal error:
> >       'AppleThreadPlanStepThroughObjCTrampoline.h' file not found
> > #include "AppleThreadPlanStepThroughObjCTrampoline.h"
> >
> > This is using the following (with a dir structure like below):
> >
> > |- llvm/
> > |- build/
> >
> > $ cd build
> > $ ../llvm/configure --enable-cxx11 --prefix=`pwd`/../install
> > $ make -j16
> >
> > I'm at this change:
> > tfiala-macbookpro:lldb tfiala$ svn info
> > Path: .
> > Working Copy Root Path: /Users/tfiala/lldb/svn/llvm/tools/lldb
> > URL: https://tfiala@llvm.org/svn/llvm-project/lldb/trunk
> > Repository Root: https://tfiala@llvm.org/svn/llvm-project
> > Repository UUID: 91177308-0d34-0410-b5e6-96231b3b80d8
> > Revision: 202527
> > Node Kind: directory
> > Schedule: normal
> > Last Changed Author: gclayton
> > Last Changed Rev: 202525
> > Last Changed Date: 2014-02-28 10:22:24 -0800 (Fri, 28 Feb 2014)
> >
> > -Todd
>
>
> Ah yes, I also have a patch (attached) for this that I forgot about.
>
> FYI, when using a CMake build, HasAVX.s is built with as instead of
> clang (it has preprocessor definitions). Renaming it to HasAVX.S
> (captial S, denoting preprocessed assembly) didn't fix the issue.
> CMake still tried to build it using as. I'm still investigating that
> issue.
>
> Cheers,
> Jevin
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140228/31f31e7a/attachment.html>
-------------- next part --------------
Index: lib/Makefile
===================================================================
--- lib/Makefile	(revision 202535)
+++ lib/Makefile	(working copy)
@@ -130,7 +130,7 @@
 	LLVMLibsOptions += -framework Foundation -framework CoreFoundation
 	LLVMLibsOptions += -framework CoreServices -framework Carbon -framework Security
 	LLVMLibsOptions += -framework DebugSymbols $(PYTHON_BUILD_FLAGS) -lobjc
-	LLVMLibsOptions += -lxml2
+	LLVMLibsOptions += -lxml2 -ledit -lpanel -lcurses
 	ifneq ($(EXPORTED_SYMBOL_FILE),)
 		LLVMLibsOptions += -Wl,-exported_symbols_list -Wl,"$(EXPORTED_SYMBOL_FILE)"
 	endif
Index: source/Plugins/SystemRuntime/MacOSX/Makefile
===================================================================
--- source/Plugins/SystemRuntime/MacOSX/Makefile	(revision 202535)
+++ source/Plugins/SystemRuntime/MacOSX/Makefile	(working copy)
@@ -11,4 +11,5 @@
 LIBRARYNAME := lldbPluginSystemRuntimeMacOSX
 BUILD_ARCHIVE = 1
 
+CPP.Flags += -I$(PROJ_SRC_DIR)/../../LanguageRuntime/ObjC/AppleObjCRuntime
 include $(LLDB_LEVEL)/Makefile