[Lldb-commits] [lldb] r202311 - A better long term fix for stopping the process when it is running by writing to the pipe that was used for cancel.

[Ed Maste]

On 26 February 2014 17:47, Greg Clayton <gclayton at apple.com> wrote:
> Author: gclayton
> Date: Wed Feb 26 16:47:33 2014
> New Revision: 202311
>
> URL: http://llvm.org/viewvc/llvm-project?rev=202311&view=rev
> Log:
> A better long term fix for stopping the process when it is running by writing to the pipe that was used for cancel.

Thanks Greg - looks good and ^C does work as expected for me after this change.

One question though (not part of this change, I just noticed in the context):

> @@ -4829,15 +4838,28 @@ public:
>      Cancel ()
>      {
>          size_t n = 1;
> -        char ch = 'q';
> +        char ch = 'q';  // Send 'q' for quit
>          m_pipe_write.Write (&ch, n);

Isn't a Windows special-case needed here too?