[Lldb-commits] [lldb] r201614 - <rdar://problem/15960553>

[Ed Maste]

On 19 February 2014 11:36, Ed Maste <emaste at freebsd.org> wrote:
> On 18 February 2014 18:48, Enrico Granata <egranata at apple.com> wrote:
>> Author: enrico
>> Date: Tue Feb 18 17:48:11 2014
>> New Revision: 201614
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=201614&view=rev
>> Log:
>> <rdar://problem/15960553>
>>
>> Fix a bug where calling SBFrame::FindValue() would cause a copy of all variables in the block to be inserted in the frame's variable list, regardless of whether those same variables were there or not - which means one could end up with a frame with lots of duplicate copies of the same variables
>
> After this change I see 10 new test failures (listed below); I haven't
> yet investigated if the tests are buggy, or if something else is now
> broken.

The first failure is:

Traceback (most recent call last):
  File "/tank/emaste/src/llvm/tools/lldb/test/lldbtest.py", line 319, in wrapper
    return func(self, *args, **kwargs)
  File "/tank/emaste/src/llvm/tools/lldb/test/lldbtest.py", line 370, in wrapper
    return func(self, *args, **kwargs)
  File "/tank/emaste/src/llvm/tools/lldb/test/python_api/process/TestProcessAPI.py",
line 58, in test_access_my_int_with_dwarf
    self.access_my_int()
  File "/tank/emaste/src/llvm/tools/lldb/test/python_api/process/TestProcessAPI.py",
line 228, in access_my_int
    self.DebugSBValue(val)
  File "/tank/emaste/src/llvm/tools/lldb/test/lldbtest.py", line 2040,
in DebugSBValue
    err.write(val.GetName() + ":\n")
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

   226          # Get the SBValue for the global variable 'my_int'.
   227          val = frame.FindValue("my_int", lldb.eValueTypeVariableGlobal)
   228          self.DebugSBValue(val)

So it appears the test does expect to find the global variable via
frame.FindValue().