[Lldb-commits] [lldb] r200950 - Removed spurious lookup of the $__lldb_expr

Sean Callanan scallanan at apple.com
Thu Feb 6 14:24:11 PST 2014


Author: spyffe
Date: Thu Feb  6 16:24:11 2014
New Revision: 200950

URL: http://llvm.org/viewvc/llvm-project?rev=200950&view=rev
Log:
Removed spurious lookup of the $__lldb_expr
selector when compiling an expression in an
Objective-C context.

<rdar://problem/15797390>

Modified:
    lldb/trunk/source/Expression/ClangASTSource.cpp
    lldb/trunk/test/lang/objc/foundation/TestObjCMethods.py

Modified: lldb/trunk/source/Expression/ClangASTSource.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ClangASTSource.cpp?rev=200950&r1=200949&r2=200950&view=diff
==============================================================================
--- lldb/trunk/source/Expression/ClangASTSource.cpp (original)
+++ lldb/trunk/source/Expression/ClangASTSource.cpp Thu Feb  6 16:24:11 2014
@@ -974,6 +974,9 @@ ClangASTSource::FindObjCMethodDecls (Nam
     }     
     ss.Flush();
     
+    if (strstr(ss.GetData(), "$__lldb"))
+        return; // we don't need any results
+    
     ConstString selector_name(ss.GetData());
     
     if (log)

Modified: lldb/trunk/test/lang/objc/foundation/TestObjCMethods.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/objc/foundation/TestObjCMethods.py?rev=200950&r1=200949&r2=200950&view=diff
==============================================================================
--- lldb/trunk/test/lang/objc/foundation/TestObjCMethods.py (original)
+++ lldb/trunk/test/lang/objc/foundation/TestObjCMethods.py Thu Feb  6 16:24:11 2014
@@ -113,14 +113,12 @@ class FoundationTestCase(TestBase):
             substrs = ["Foundation`-[NSAutoreleasePool release]"])
 
     @dsym_test
-    @expectedFailureDarwin(15797390)
     def test_expression_lookups_objc_dsym(self):
         """Test running an expression detect spurious debug info lookups (dSYM)."""
         self.buildDsym()
         self.expression_lookups_objc()
 
     @dwarf_test
-    @expectedFailureDarwin(15797390)
     def test_expression_lookups_objc_dwarf(self):
         """Test running an expression detect spurious debug info lookups (DWARF)."""
         self.buildDwarf()





More information about the lldb-commits mailing list