[Lldb-commits] [PATCH] FreeBSD watchpoint support

[Ed Maste]

================
Comment at: source/Plugins/Process/FreeBSD/ProcessMonitor.cpp:117
@@ +116,3 @@
+            struct dbreg *r = (struct dbreg *) addr;
+            char setget = (req == PT_GETDBREGS) ? 'G' : 'S'; 
+
----------------
FYI git apply complained about whitespace on these lines:

/home/emaste/D2572.vs6513.id6823.whitespaceignore-all.diff:52: trailing whitespace.
            char setget = (req == PT_GETDBREGS) ? 'G' : 'S'; 
/home/emaste/D2572.vs6513.id6823.whitespaceignore-all.diff:54: trailing whitespace.
            for (int i = 0; i <= 7; i++) 
/home/emaste/D2572.vs6513.id6823.whitespaceignore-all.diff:97: trailing whitespace.
        else 
/home/emaste/D2572.vs6513.id6823.whitespaceignore-all.diff:272: trailing whitespace.
    


================
Comment at: source/Plugins/Process/POSIX/POSIXThread.cpp:80
@@ +79,3 @@
+            bool status = EnableHardwareWatchpoint(wp.get());
+#else
+            EnableHardwareWatchpoint(wp.get());
----------------
or perhaps just
(void)status;
to avoid the #ifdefs



http://llvm-reviews.chandlerc.com/D2572