[Lldb-commits] [lldb] r200246 - convert gdb-remote 'A' launch to use LaunchProcess ()

Todd Fiala tfiala at google.com
Mon Jan 27 12:44:50 PST 2014

Author: tfiala
Date: Mon Jan 27 14:44:50 2014
New Revision: 200246

URL: http://llvm.org/viewvc/llvm-project?rev=200246&view=rev
convert gdb-remote 'A' launch to use LaunchProcess ()

This change modifies the 'A' command handler's launch code to launch
with LaunchProcess (). The net effect is that the default process
monitoring that LaunchProcess () adds will kick in, allowing the
GDBRemoteCommunicationServer to be able to reap processes started with
this facility correctly. Later, in the case of lldb-gdbserver, we'll
also have the proper process monitoring going on to really debug the
inferior process.


Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp?rev=200246&r1=200245&r2=200246&view=diff
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp Mon Jan 27 14:44:50 2014
@@ -811,8 +811,11 @@ GDBRemoteCommunicationServer::Handle_A (
     if (success)
+        // FIXME: remove linux restriction once eLaunchFlagDebug is supported
+#if !defined (__linux__)
         m_process_launch_info.GetFlags().Set (eLaunchFlagDebug);
-        m_process_launch_error = Host::LaunchProcess (m_process_launch_info);
+        m_process_launch_error = LaunchProcess ();
         if (m_process_launch_info.GetProcessID() != LLDB_INVALID_PROCESS_ID)
             return SendOKResponse ();

More information about the lldb-commits mailing list