[Lldb-commits] [PATCH] FreeBSD watchpoint support

[Ed Maste]

================
Comment at: source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_x86.cpp:113
@@ +112,3 @@
+
+#if defined(__FreeBSD__)
+    if (reg >= m_reg_info.first_dr)
----------------
Instead of the FreeBSD-specific case here, can we just put the logic into ::ReadRegisterValue, giving it visibility into our register numbering?

================
Comment at: source/Plugins/Process/FreeBSD/ProcessMonitor.h:127
@@ +126,3 @@
+    /// This method is provided for use by RegisterContextFreeBSD derivatives.
+    /// FIXME: ???? The FreeBSD implementation of this function should use tid in order
+    ///        to enable support for debugging threaded programs.
----------------
I don't follow the FIXME comment - it is using the tid, no?


http://llvm-reviews.chandlerc.com/D2572