[Lldb-commits] [lldb] r198962 - Fixed the assertion test case.

Greg Clayton gclayton at apple.com
Fri Jan 10 14:22:44 PST 2014


Author: gclayton
Date: Fri Jan 10 16:22:44 2014
New Revision: 198962

URL: http://llvm.org/viewvc/llvm-project?rev=198962&view=rev
Log:
Fixed the assertion test case.


Modified:
    lldb/trunk/test/functionalities/inferior-assert/TestInferiorAssert.py

Modified: lldb/trunk/test/functionalities/inferior-assert/TestInferiorAssert.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/inferior-assert/TestInferiorAssert.py?rev=198962&r1=198961&r2=198962&view=diff
==============================================================================
--- lldb/trunk/test/functionalities/inferior-assert/TestInferiorAssert.py (original)
+++ lldb/trunk/test/functionalities/inferior-assert/TestInferiorAssert.py Fri Jan 10 16:22:44 2014
@@ -169,9 +169,13 @@ class AssertingInferiorTestCase(TestBase
 
             self.runCmd("frame select " + str(frame.GetFrameID()), RUN_SUCCEEDED)
 
-            # TODO: Disassembly does not specify '->' for the PC for a non-terminal frame for a function with a tail call.
+            # Don't expect the function name to be in the disassembly as the assert
+            # function might be a no-return function where the PC is past the end
+            # of the function and in the next function. We also can't back the PC up
+            # because we don't know how much to back it up by on targets with opcodes
+            # that have differing sizes
             self.expect("disassemble -a %s" % frame.GetPC(),
-                substrs = [frame.GetFunctionName()])
+                substrs = ['->'])
 
     def check_expr_in_main(self, thread):
         depth = thread.GetNumFrames()





More information about the lldb-commits mailing list