[Lldb-commits] [lldb] r197859 - The one-line printing facility is used by StringSummaryFormat, but that's no reason to have it be part of the public interface of ValueObjectPrinter

Enrico Granata egranata at apple.com
Sat Dec 21 00:19:44 PST 2013


Author: enrico
Date: Sat Dec 21 02:19:44 2013
New Revision: 197859

URL: http://llvm.org/viewvc/llvm-project?rev=197859&view=rev
Log:
The one-line printing facility is used by StringSummaryFormat, but that's no reason to have it be part of the public interface of ValueObjectPrinter
That's what friendship is for


Modified:
    lldb/trunk/include/lldb/DataFormatters/ValueObjectPrinter.h

Modified: lldb/trunk/include/lldb/DataFormatters/ValueObjectPrinter.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/DataFormatters/ValueObjectPrinter.h?rev=197859&r1=197858&r2=197859&view=diff
==============================================================================
--- lldb/trunk/include/lldb/DataFormatters/ValueObjectPrinter.h (original)
+++ lldb/trunk/include/lldb/DataFormatters/ValueObjectPrinter.h Sat Dec 21 02:19:44 2013
@@ -265,9 +265,6 @@ public:
     bool
     PrintValueObject ();
     
-    bool
-    PrintChildrenOneLiner (bool hide_names);
-    
 protected:
     
     // only this class (and subclasses, if any) should ever be concerned with
@@ -366,6 +363,9 @@ protected:
     PrintChildrenIfNeeded (bool value_printed,
                            bool summary_printed);
     
+    bool
+    PrintChildrenOneLiner (bool hide_names);
+    
 private:
     
     ValueObject *m_orig_valobj;
@@ -386,6 +386,8 @@ private:
     std::string m_summary;
     std::string m_error;
     
+    friend class StringSummaryFormat;
+    
     DISALLOW_COPY_AND_ASSIGN(ValueObjectPrinter);
 };
     





More information about the lldb-commits mailing list