[Lldb-commits] [PATCH] Request for review: Fix build-llvm.pl

[Greg Clayton]

Looks good.

On Dec 1, 2013, at 10:58 AM, Jean-Daniel Dupas <devlists at shadowlab.org> wrote:

> Jean-Daniel added you to the CC list for the revision "Request for review: Fix build-llvm.pl".
> 
> - Stop to try to rebuild llvm on each invocation by removing the invalid library entry libLLVMArchive.a which no longer exists.
> - Remove the useless ranlib invocation. "libtools -static" automatically takes care of the archive table of content.
> 
> http://llvm-reviews.chandlerc.com/D2296
> 
> Files:
>  scripts/build-llvm.pl
> 
> Index: scripts/build-llvm.pl
> ===================================================================
> --- scripts/build-llvm.pl
> +++ scripts/build-llvm.pl
> @@ -64,7 +64,6 @@
>     "$llvm_configuration/lib/libclangSema.a",
>     "$llvm_configuration/lib/libclangSerialization.a",
>     "$llvm_configuration/lib/libLLVMAnalysis.a",
> -    "$llvm_configuration/lib/libLLVMArchive.a",
>     "$llvm_configuration/lib/libLLVMARMAsmParser.a",
>     "$llvm_configuration/lib/libLLVMARMAsmPrinter.a",
>     "$llvm_configuration/lib/libLLVMARMCodeGen.a",
> @@ -205,7 +204,7 @@
>                 if (!-d $llvm_dstroot_arch_bin)
>                 {
>                     do_command ("mkdir -p '$llvm_dstroot_arch_bin'", "making llvm build arch bin directory '$llvm_dstroot_arch_bin'", 1);
> -                    my @tools = ("ar", "nm", "ranlib", "strip", "lipo", "ld", "as");
> +                    my @tools = ("ar", "nm", "strip", "lipo", "ld", "as");
>                     my $script_mode = 0755;
>                     my $prog;
>                     for $prog (@tools)
> @@ -390,7 +389,6 @@
>     }
>     close (FILES);
>     do_command ("libtool -static -o '$arch_output_file' -filelist '$files'");
> -    do_command ("ranlib '$arch_output_file'");
> 
>     foreach $object_dir (@object_dirs)
>     {
> <D2296.1.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits