[Lldb-commits] [PATCH] FreeBSD threaded inferior support

John Wolfe jlw at xinuos.com
Tue Nov 26 18:24:44 PST 2013

  Things look good.  I do have questions about two methods which may really be a factor of my becoming familiar with the lldb source code.


      "resume_signal = 0"

  Should this not be LLDB_INVALID_SIGNAL_NUMBER?   The comments on SingleStep() and Resume() suggest that any other value will cause that signal to be delivered to the process.

  What is the function of the "do_step = true" in the "m_suspended_tids" loop?


      Is it "safe" to simply "return 0" if either of the malloc() or PTRACE() calls fail.  Acknowledged that if malloc() fails, lldb is about to fall over.   Is there any instance when this PTRACE() call can fail when there are known threads (tdcnt > 0) and the correct amount of space has been malloc'ed.

  It is nit-picking, but should these not be covered by assertions?

  -- John


More information about the lldb-commits mailing list