[Lldb-commits] [lldb] r195657 - Fix issue from r166732 found by Andrew Kaylor

Ed Maste emaste at freebsd.org
Mon Nov 25 08:36:48 PST 2013

Author: emaste
Date: Mon Nov 25 10:36:47 2013
New Revision: 195657

URL: http://llvm.org/viewvc/llvm-project?rev=195657&view=rev
Fix issue from r166732 found by Andrew Kaylor

>From Jim Ingham's email:
  It does look like ThreadPlanStepInRange test is some kind of thinko.
  In practice, in this case it is probably safe to run only one thread
  when doing the "step through" since that generally involved running
  from a shared library stub to its target.  That could deadlock if the
  dynamic loader has to fix up the symbol, and another thread is in the
  middle of doing that.  But that doesn't seem to be very common, or at
  least the code is clearly wrong but I haven't had any reports of this
  causing deadlocks...


Modified: lldb/trunk/source/Target/ThreadPlanStepInRange.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanStepInRange.cpp?rev=195657&r1=195656&r2=195657&view=diff
--- lldb/trunk/source/Target/ThreadPlanStepInRange.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanStepInRange.cpp Mon Nov 25 10:36:47 2013
@@ -132,9 +132,9 @@ ThreadPlanStepInRange::ShouldStop (Event
         bool stop_others;
         if (m_stop_others == lldb::eOnlyThisThread)
-            stop_others = false;
-        else
             stop_others = true;
+        else
+            stop_others = false;
         FrameComparison frame_order = CompareCurrentFrameToStartFrame();

More information about the lldb-commits mailing list