[Lldb-commits] [lldb] r195435 - Fix for PECOFF GetArchitecture

Colin Riley colin at codeplay.com
Fri Nov 22 01:35:12 PST 2013


Author: domipheus
Date: Fri Nov 22 03:35:12 2013
New Revision: 195435

URL: http://llvm.org/viewvc/llvm-project?rev=195435&view=rev
Log:
Fix for PECOFF GetArchitecture

0 as CPU subtype never matches anything (at least, it doesn't match x86_64 windows binaries, of which there are correct arch definitions for). It should be created with LLDB_INVALID_CPUTYPE. 

Modified:
    lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

Modified: lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp?rev=195435&r1=195434&r2=195435&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp Fri Nov 22 03:35:12 2013
@@ -922,7 +922,7 @@ ObjectFilePECOFF::GetArchitecture (ArchS
         case llvm::COFF::IMAGE_FILE_MACHINE_ARM:
         case llvm::COFF::IMAGE_FILE_MACHINE_ARMV7:
         case llvm::COFF::IMAGE_FILE_MACHINE_THUMB:
-            arch.SetArchitecture (eArchTypeCOFF, machine, 0);
+            arch.SetArchitecture (eArchTypeCOFF, machine, LLDB_INVALID_CPUTYPE);
             return true;
         default:
             break;





More information about the lldb-commits mailing list