[Lldb-commits] [lldb] r193877 - Use 0x00... as the magic constant to write in st0. That should be reliably 0 regardless of OS/hardware

[Richard Mitton]

Hi,
Doesn't this just delete the test?
The value that was there should decode exactly regardless of what OS 
you're running.

Richard Mitton
richard at codersnotes.com

On 11/01/2013 11:19 AM, Enrico Granata wrote:
> Author: enrico
> Date: Fri Nov  1 13:19:05 2013
> New Revision: 193877
>
> URL: http://llvm.org/viewvc/llvm-project?rev=193877&view=rev
> Log:
> Use 0x00... as the magic constant to write in st0. That should be reliably 0 regardless of OS/hardware
>
> Modified:
>      lldb/trunk/test/functionalities/register/TestRegisters.py
>
> Modified: lldb/trunk/test/functionalities/register/TestRegisters.py
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/register/TestRegisters.py?rev=193877&r1=193876&r2=193877&view=diff
> ==============================================================================
> --- lldb/trunk/test/functionalities/register/TestRegisters.py (original)
> +++ lldb/trunk/test/functionalities/register/TestRegisters.py Fri Nov  1 13:19:05 2013
> @@ -186,9 +186,9 @@ class RegisterCommandsTestCase(TestBase)
>           new_value = "{0x01 0x02 0x03 0x00 0x00 0x00 0x00 0x00 0x09 0x0a 0x2f 0x2f 0x2f 0x2f 0x0e 0x0f}"
>           self.vector_write_and_read(currentFrame, "xmm15", new_value, False)
>   
> -        self.runCmd("register write " + st0regname + " \"{0x00 0x00 0x00 0x00 0x00 0x00 0x40 0x9a 0x09 0x40}\"")
> +        self.runCmd("register write " + st0regname + " \"{0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00}\"")
>           self.expect("register read " + st0regname + " --format f",
> -            substrs = ['stmm0 = 1234'])
> +            substrs = ['stmm0 = 0'])
>   
>           has_avx = False
>           registerSets = currentFrame.GetRegisters() # Returns an SBValueList.
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits