[Lldb-commits] [PATCH] Introduce DWARFDataExtractor for 64-Bit DWARF parsing

[Greg Clayton]

The only change I would make now is to always set the "m_is_dwarf64" when GetDWARFInitialLength() is called:

uint64_t
DWARFDataExtractor::GetDWARFInitialLength(lldb::offset_t *offset_ptr) const
{
    uint64_t length = GetU32(offset_ptr);
    m_is_dwarf64 = (length == UINT32_MAX);
    if (m_is_dwarf64)
        length = GetU64(offset_ptr);
    return length;
}

Fix this and you are good to checkin.

Greg

On Oct 23, 2013, at 5:47 PM, Ed Maste <emaste at freebsd.org> wrote:

>  Undo MappedHash templatization; just use the base DataExtractor class.
> 
> http://llvm-reviews.chandlerc.com/D2007
> 
> CHANGE SINCE LAST DIFF
>  http://llvm-reviews.chandlerc.com/D2007?vs=5107&id=5109#toc
> 
> Files:
>  source/Plugins/SymbolFile/DWARF/CMakeLists.txt
>  source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h
>  source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h
>  source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h
>  source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.h
>  source/Plugins/SymbolFile/DWARF/DWARFDebugArangeSet.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFDebugArangeSet.h
>  source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.h
>  source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h
>  source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFDebugLine.h
>  source/Plugins/SymbolFile/DWARF/DWARFDebugMacinfo.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFDebugMacinfo.h
>  source/Plugins/SymbolFile/DWARF/DWARFDebugMacinfoEntry.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFDebugMacinfoEntry.h
>  source/Plugins/SymbolFile/DWARF/DWARFDebugPubnames.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFDebugPubnames.h
>  source/Plugins/SymbolFile/DWARF/DWARFDebugPubnamesSet.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFDebugPubnamesSet.h
>  source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h
>  source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFFormValue.h
>  source/Plugins/SymbolFile/DWARF/DWARFLocationDescription.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFLocationDescription.h
>  source/Plugins/SymbolFile/DWARF/DWARFLocationList.cpp
>  source/Plugins/SymbolFile/DWARF/DWARFLocationList.h
>  source/Plugins/SymbolFile/DWARF/HashedNameToDIE.h
>  source/Plugins/SymbolFile/DWARF/NameToDIE.cpp
>  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
>  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
> <D2007.3.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits