[Lldb-commits] [lldb] r192511 - <rdar://problem/15192088>

Enrico Granata egranata at apple.com
Fri Oct 11 15:09:26 PDT 2013


Author: enrico
Date: Fri Oct 11 17:09:26 2013
New Revision: 192511

URL: http://llvm.org/viewvc/llvm-project?rev=192511&view=rev
Log:
<rdar://problem/15192088>

gdb-format a (as in p/a) would fail as it needed to set a byte size (unsurprisingly enough)
This should be acknowledged by the condition check and not cause a failure


Modified:
    lldb/trunk/source/Interpreter/OptionGroupFormat.cpp

Modified: lldb/trunk/source/Interpreter/OptionGroupFormat.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/OptionGroupFormat.cpp?rev=192511&r1=192510&r2=192511&view=diff
==============================================================================
--- lldb/trunk/source/Interpreter/OptionGroupFormat.cpp (original)
+++ lldb/trunk/source/Interpreter/OptionGroupFormat.cpp Fri Oct 11 17:09:26 2013
@@ -158,7 +158,9 @@ OptionGroupFormat::SetOptionValue (Comma
                 else
                 {
                     // Byte size is disabled, make sure it wasn't specified
-                    if (byte_size > 0)
+                    // but if this is an address, it's actually necessary to
+                    // specify one so don't error out
+                    if (byte_size > 0 && format != lldb::eFormatAddressInfo)
                     {
                         error.SetErrorString ("this command doesn't support specifying a byte size");
                         return error;





More information about the lldb-commits mailing list