[Lldb-commits] [PATCH] LLDB Command line driver windows changes.

Greg Clayton gclayton at apple.com
Thu Oct 10 12:48:47 PDT 2013

I didn't catch the spin lock. We should either use std::atomic or there as std::condition_variable if condition variables are needed.

On Oct 10, 2013, at 11:45 AM, Richard Mitton <richard at codersnotes.com> wrote:

>  Why does this replace a condition variable with a 10 millisecond
>  spinlock? Spinlocks are bad.
>  I don't know about the C++11 standard, but if you want the same effect
>  on Windows you'd just use SetEvent.
>  Also don't use volatile. In fact, never use volatile. m_output_flushed
>  is a class variable, so the compiler knows to reload it each time anyway.
>  Richard Mitton
>  richard at codersnotes.com
> http://llvm-reviews.chandlerc.com/D1785
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

More information about the lldb-commits mailing list