[Lldb-commits] [PATCH] LLDB Command line driver windows changes.

Greg Clayton gclayton at apple.com
Tue Oct 8 13:24:22 PDT 2013


I would suggest the following:

1 - Instead of pthread_mutex_t use C++11 mutex classes
2 - Instead of pthread_cond_t use C++11 condition classes
3 - Remove Mutex.cpp
4 - Use std::thread/std::function from C++11 for any threading

So in general, since we require C++11, lets use that instead of an extra host layer.


On Sep 30, 2013, at 4:07 AM, Aidan Dodds <aidan.dodds at googlemail.com> wrote:

> Modifications to allow compilation and execution on a windows system.
> 
> http://llvm-reviews.chandlerc.com/D1785
> 
> Files:
>  tools/CMakeLists.txt
>  tools/driver/CMakeLists.txt
>  tools/driver/Driver.cpp
>  tools/driver/Driver.h
>  tools/driver/ELWrapper.cpp
>  tools/driver/ELWrapper.h
>  tools/driver/GetOptWrapper.cpp
>  tools/driver/GetOptWrapper.h
>  tools/driver/IOChannel.cpp
>  tools/driver/IOChannel.h
>  tools/driver/Mutex.cpp
>  tools/driver/Platform.cpp
>  tools/driver/Platform.h
> <D1785.1.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits




More information about the lldb-commits mailing list