[Lldb-commits] [PATCH] Opcode endianness proof-of-concept

[Ed Maste]

================
Comment at: include/lldb/Core/Opcode.h:18
@@ -17,2 +17,3 @@
 // Other libraries and framework includes
+#include "llvm/Support/MathExtras.h"
 // Project includes
----------------
A little unfortunate to have to bring these in

================
Comment at: source/Core/Opcode.cpp:105
@@ +104,3 @@
+            {
+                // 32 bit thumb instruction, we need to sizzle this a bit
+                swap_buf[0] = m_data.inst.bytes[2];
----------------
Just noticed; this should probably be "swizzle"

================
Comment at: include/lldb/Core/Opcode.h:105
@@ -102,2 +105,2 @@
             {
             case Opcode::eTypeInvalid:  break;
----------------
Note that GetOpcode8, GetOpcode16, GetOpcode64 are not actually used anywhere


http://llvm-reviews.chandlerc.com/D1838