[Lldb-commits] [PATCH] Make CommandObjectProcess check process state before calling WaitForProcessToStop

[Malea, Daniel]

Yes, originally I had the state-checking logic in WaitForProcessToStop() and noticed some regressions, but I didn't investigate them too much...I will take another look.

Thanks,
Dan

-----Original Message-----
From: jingham at apple.com [mailto:jingham at apple.com] 
Sent: Thursday, October 3, 2013 7:09 PM
To: Malea, Daniel
Cc: lldb-commits at cs.uiuc.edu
Subject: Re: [Lldb-commits] [PATCH] Make CommandObjectProcess check process state before calling WaitForProcessToStop

Shouldn't this be done in WaitForProcessToStop?

Jim

On Oct 3, 2013, at 3:34 PM, Malea, Daniel <daniel.malea at intel.com> wrote:

> Hi all,
> 
> I noticed a race condition where a process is launched and hits a breakpoint while CommandObjectProcessLaunch is still in DoExecute. The effect I'm seeing is that if Process::WaitForProcessToStop() is called on a stopped process, LLDB hangs.
> 
> This patch fixes the issue by checking the process state before calling WaitForProcessToStop from CommandObjectProcessLaunch. I think there might still be a race condition in between getting the state and checking if StateIsStoppedState, but I'm not sure what process mutex to acquire in the command object while checking the state, or if that approach is any better..
> 
> Comments welcome!
> 
> Thanks,
> Dan
> <command_object_process_check_state.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits