[Lldb-commits] [lldb] r191620 - * Improve the wording (thanks to Ed Maste for the suggestion)

Sylvestre Ledru sylvestre at debian.org
Sat Sep 28 08:57:38 PDT 2013


Author: sylvestre
Date: Sat Sep 28 10:57:37 2013
New Revision: 191620

URL: http://llvm.org/viewvc/llvm-project?rev=191620&view=rev
Log:
* Improve the wording (thanks to Ed Maste for the suggestion)
* Add a TODO item


Modified:
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp?rev=191620&r1=191619&r2=191620&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp Sat Sep 28 10:57:37 2013
@@ -762,10 +762,12 @@ GDBRemoteCommunicationServer::Handle_qLa
         char connect_url[PATH_MAX];
         Error error;
         std::string hostname;
+        // TODO: /tmp/ should not be hardcoded. User might want to override /tmp
+        // with the TMPDIR environnement variable
         char unix_socket_name[PATH_MAX] = "/tmp/XXXXXX";
         if (::mkstemp (unix_socket_name) == -1)
         {
-            error.SetErrorStringWithFormat("failed to make temporary path for a unix socket with errno: %s", strerror(errno));
+            error.SetErrorStringWithFormat("failed to make temporary path for a unix socket: %s", strerror(errno));
         }
         else
         {





More information about the lldb-commits mailing list