[Lldb-commits] [lldb] r189934 - Remove <windows.h> from lldb-types.h.

[Virgile Bello]

OK to commit?


On Sun, Sep 8, 2013 at 5:52 PM, Virgile Bello <virgile.bello at gmail.com>wrote:

> Thinking about it again, including <atomic> from LLDB headers has some
> drawbacks:
> - any project including LLDB to also be C++11 (not sure if LLDB includes
> should support usage from non C++11 projects?)
> - also for Win32, it prevents including LLDB headers in any CLR (C++/CLI)
> project since <atomic> is not CLR compatible (happening in my case when
> writing a LLDB MSVC debugger).
>
> Actually I found out that on Windows, there is <intrin.h> that provides
> _InterlockedIncrement without pulling the whole <Windows.h>, so it wouldn't
> be a problem anymore to keep it in .h, factorized in a common LLDB header,
> similar to LLVM Atomic.h.
>
> Patch is attached. Let me know your thoughts.
>
> Virgile
>
>
>
> On Fri, Sep 6, 2013 at 5:09 AM, Greg Clayton <gclayton at apple.com> wrote:
>
>> Looks good.
>>
>> On Sep 5, 2013, at 5:48 AM, Virgile Bello <virgile.bello at gmail.com>
>> wrote:
>>
>> > <lldb-atomic.patch>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130913/1d85c742/attachment.html>