[Lldb-commits] [lldb] r189934 - Remove <windows.h> from lldb-types.h.

Virgile Bello virgile.bello at gmail.com
Sun Sep 8 08:52:09 PDT 2013

Thinking about it again, including <atomic> from LLDB headers has some
- any project including LLDB to also be C++11 (not sure if LLDB includes
should support usage from non C++11 projects?)
- also for Win32, it prevents including LLDB headers in any CLR (C++/CLI)
project since <atomic> is not CLR compatible (happening in my case when
writing a LLDB MSVC debugger).

Actually I found out that on Windows, there is <intrin.h> that provides
_InterlockedIncrement without pulling the whole <Windows.h>, so it wouldn't
be a problem anymore to keep it in .h, factorized in a common LLDB header,
similar to LLVM Atomic.h.

Patch is attached. Let me know your thoughts.


On Fri, Sep 6, 2013 at 5:09 AM, Greg Clayton <gclayton at apple.com> wrote:

> Looks good.
> On Sep 5, 2013, at 5:48 AM, Virgile Bello <virgile.bello at gmail.com> wrote:
> > <lldb-atomic.patch>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130909/a2623ce8/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lldb-atomic-v2.patch
Type: application/octet-stream
Size: 3483 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130909/a2623ce8/attachment.obj>

More information about the lldb-commits mailing list