[Lldb-commits] [lldb] r190149 - Correct logic error found by inspection.

Ed Maste emaste at freebsd.org
Fri Sep 6 05:43:15 PDT 2013

Author: emaste
Date: Fri Sep  6 07:43:14 2013
New Revision: 190149

URL: http://llvm.org/viewvc/llvm-project?rev=190149&view=rev
Correct logic error found by inspection.

>From Jim's post on the lldb-dev mailing list:

  This code is there as a backstop for when the unwinder drops a frame at
  the beginning of new function/trampoline or whatever.

  In the (older_ctx_is_equivalent == false) case we will see if we are at
  a trampoline function that somebody knows how to get out of, and
  otherwise we will stop.


Modified: lldb/trunk/source/Target/ThreadPlanStepOverRange.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanStepOverRange.cpp?rev=190149&r1=190148&r2=190149&view=diff
--- lldb/trunk/source/Target/ThreadPlanStepOverRange.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanStepOverRange.cpp Fri Sep  6 07:43:14 2013
@@ -121,7 +121,7 @@ ThreadPlanStepOverRange::ShouldStop (Eve
             // in so I left out the target check.  And sometimes the module comes in as the .o file from the
             // inlined range, so I left that out too...
-            bool older_ctx_is_equivalent = true;
+            bool older_ctx_is_equivalent = false;
             if (m_addr_context.comp_unit)
                 if (m_addr_context.comp_unit == older_context.comp_unit)

More information about the lldb-commits mailing list