[Lldb-commits] [PATCH] Fix warnings and one set of build issues on linux

[Eric Christopher]

Everyone else's comments were good, but here's a brief example:

class A {
   int a;
   int b;
   A(int c) a(c++), b(c) {};
}

It's a bit contrived, but if you've got side effects in initializers
then you could have a bad time if they're in a different order than
you expect. An example for the stackoverflow commentary below.

-eric

On Fri, Aug 30, 2013 at 2:49 AM, Abid, Hafiz <Hafiz_Abid at mentor.com> wrote:
> Hi Eric,
> I have a comment about the change in GDBRemoteCommunicationClient.cpp. I have no objection to the change but I was wondering why was it needed.
>
> Regards,
> Abid
>
>> -----Original Message-----
>> From: lldb-commits-bounces at cs.uiuc.edu [mailto:lldb-commits-
>> bounces at cs.uiuc.edu] On Behalf Of Eric Christopher
>> Sent: 30 August 2013 03:12
>> To: lldb-commits at cs.uiuc.edu
>> Subject: [Lldb-commits] [PATCH] Fix warnings and one set of build issues on
>> linux
>>
>> Here's a patch to fix a pile of warnings using ToT clang to build lldb. Mostly
>> the deprecation of "register", but a couple of others around floating point
>> constants etc.
>>
>> The one build fix is in IOChannel and seems that for, at least my ubuntu
>> machine, we need to use the same readline that FreeBSD does.
>>
>> Thoughts/Objections? OK?
>>
>> -eric