[Lldb-commits] [lldb] r189365 - Remove need of <functional> for CommandObjectCommands.

[Enrico Granata]

> Yes sorry I meant <initializer_list>.
> 
> Actually I thought this include was explicitely needed for MSVC12 port...
> but I've just been testing again, it seems not necessary anymore, maybe it was fixed in the latest version -- my bad.
> 
> However for this specific case with std::pair, it felt easier to just use normal constructor instead of initializer_list since it doesn't make code much different
> (as opposed to cases such as std::vector<int> a = { 1, 1, 1 } where it makes much more sense vs using many verbose push_back).
> 

Agreed. Not a big deal.

> Also, even though it's not a big priority for me, it should also make it easier to maintain a future MSVC11 branch (which doesn't support initializer_list) by using this feature only where it actually matters, so that it minimizes differences.
> 
> Of course I won't try to remove it from all the other useful situations where it's used.
> 
> Hopes that make sense, and let me know if you prefer me to revert, no problem for me.


No, no need to revert.
My main concern was whether there was a good reason for us to refrain entirely from using the initializer_list. The assumption we are developing with is that lldb is a C++11 project and as such can use all the standard features of C++11

All is good :)

Enrico Granata
📩 egranata@.com
☎️ 27683


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130827/b9b41d9e/attachment.html>