[Lldb-commits] [PATCH] MSVC port step 1: cleanup some includes and small code changes.

Virgile Bello virgile.bello at gmail.com
Sun Aug 25 09:12:41 PDT 2013


Some small improvements (first step of MSVC port):
- Remove unecessary includes, esp. <unistd.h> and <stdbool.h> (should be included through lldb-types.h)
- Add <functional> and/or <string> when necessary.
- Use standard boolean operators in CXXFormatterFunctions.cpp.
- Rename sd_regs into _sd_regs to avoid type clash.
- Use std::pair constructor in CommandObjectCommands.cpp (otherwise I could just include <functional>, but probably not really necessary in that case).

If required, I can commit in 4 separate patches.

It compiles on Linux and MinGW (I'll try to setup a MacOSX host soon to check compilation against it myself).

http://llvm-reviews.chandlerc.com/D1510

Files:
  include/lldb/Breakpoint/BreakpointSiteList.h
  include/lldb/Core/Debugger.h
  include/lldb/Core/Flags.h
  include/lldb/Core/Log.h
  include/lldb/Core/UUID.h
  include/lldb/Core/dwarf.h
  include/lldb/DataFormatters/FormatClasses.h
  include/lldb/DataFormatters/TypeSummary.h
  include/lldb/DataFormatters/TypeSynthetic.h
  include/lldb/Expression/IRForTarget.h
  include/lldb/Host/Symbols.h
  include/lldb/Symbol/ClangNamespaceDecl.h
  include/lldb/Symbol/TypeList.h
  include/lldb/lldb-types.h
  source/Commands/CommandObjectCommands.cpp
  source/Core/Log.cpp
  source/DataFormatters/CXXFormatterFunctions.cpp
  source/Host/common/Host.cpp
  source/Host/common/Mutex.cpp
  source/Host/common/Terminal.cpp
  source/Host/windows/Mutex.cpp
  source/Plugins/Instruction/ARM/EmulationStateARM.h
  source/Plugins/SymbolFile/DWARF/DWARFDefines.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1510.1.patch
Type: text/x-patch
Size: 9830 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130825/13ed8e18/attachment.bin>


More information about the lldb-commits mailing list