[Lldb-commits] [PATCH] Initial support for building debugserver with cmake (on Mac OS X)

[Malea, Daniel]

Thanks for the comments!

I agree that libdebugserver.cpp looks like dead code. To keep Cmake happy,
it's not sufficient to remove the file from the list of sources; we'd need
to remove it from the directory as well, otherwise the build breaks
because of "unknown source files".

Does anyone have any issues with removing libdebugserver.cpp? It doesn't
look like it's been built in a while.. If nobody complains, I will remove
this file when I commit this patch.


Thanks,
Dan

On 2013-08-08 4:51 PM, "Filipe Cabecinhas"
<filcab+llvm.phabricator at gmail.com> wrote:

>
>  I annotated two places to be changed (libdebugserver.cpp in CMakeLists,
>and the name of the codesign identity.
>  Other than that, LGTM.
>
>
>================
>Comment at: tools/debugserver/source/MacOSX/CMakeLists.txt:47
>@@ +46,3 @@
>+# Sign the debugserver binary
>+set (CODESIGN_IDENTITY lldb)
>+set (CODESIGN_ALLOCATE
>/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolc
>hain/usr/bin/codesign_allocate)
>----------------
>This should be the same as in Xcode: lldb_codesign
>
>
>================
>Comment at: tools/debugserver/source/CMakeLists.txt:29
>@@ +28,3 @@
>+  DNBThreadResumeActions.cpp
>+  libdebugserver.cpp
>+  PseudoTerminal.cpp
>----------------
>libdebugserver.cpp is not in the Xcode project. It seems like dead code.
>
>
>http://llvm-reviews.chandlerc.com/D1331