[Lldb-commits] [lldb] r187480 - Reverts r187449 (report_fatal_error) in favor of a log message since

Ashok Thirumurthi ashok.thirumurthi at intel.com
Tue Jul 30 20:56:46 PDT 2013

Author: athirumu
Date: Tue Jul 30 22:56:45 2013
New Revision: 187480

URL: http://llvm.org/viewvc/llvm-project?rev=187480&view=rev
Reverts r187449 (report_fatal_error) in favor of a log message since
the extra check introduces 22 new test failures with the LLDB clang buildbot.

Note that the unhandled DWARF_OP codes in DWARFExpression::Evaluate don't cause test failures if the check is ignored.


Modified: lldb/trunk/source/Expression/DWARFExpression.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/DWARFExpression.cpp?rev=187480&r1=187479&r2=187480&view=diff
--- lldb/trunk/source/Expression/DWARFExpression.cpp (original)
+++ lldb/trunk/source/Expression/DWARFExpression.cpp Tue Jul 30 22:56:45 2013
@@ -11,8 +11,6 @@
 #include <vector>
-#include "llvm/Support/ErrorHandling.h"
 #include "lldb/Core/DataEncoder.h"
 #include "lldb/Core/dwarf.h"
 #include "lldb/Core/Log.h"
@@ -2662,7 +2660,9 @@ DWARFExpression::Evaluate
-            llvm::report_fatal_error("Unhandled DWARF expression opcode! Please file a bug at llvm.org/bugs and attach the binary you were debugging.");
+            if (log)
+                log->Printf("Unhandled opcode %s in DWARFExpression.", DW_OP_value_to_name(op));
+            break;

More information about the lldb-commits mailing list