[Lldb-commits] [lldb] r186912 - Fixed a potential crash in the GetOSVersion code

[Sean Callanan]

Author: spyffe
Date: Mon Jul 22 20:38:41 2013
New Revision: 186912

URL: http://llvm.org/viewvc/llvm-project?rev=186912&view=rev
Log:
Fixed a potential crash in the GetOSVersion code
caused by a CFStringRef going out of scope.

Modified:
    lldb/trunk/source/Host/macosx/Host.mm

Modified: lldb/trunk/source/Host/macosx/Host.mm
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/macosx/Host.mm?rev=186912&r1=186911&r2=186912&view=diff
==============================================================================
--- lldb/trunk/source/Host/macosx/Host.mm (original)
+++ lldb/trunk/source/Host/macosx/Host.mm Mon Jul 22 20:38:41 2013
@@ -1044,7 +1044,7 @@ Host::GetOSVersion
                 {
                     CFStringRef product_version_cfstr = (CFStringRef) product_version_value;
                     product_version_str = CFStringGetCStringPtr(product_version_cfstr, kCFStringEncodingUTF8);
-                    if (product_version_str == NULL) {
+                    if (product_version_str != NULL) {
                         if (CFStringGetCString(product_version_cfstr, buffer, 256, kCFStringEncodingUTF8))
                             product_version_str = buffer;
                     }