[Lldb-commits] [lldb] r186207 - Introduces core file support for Linux x86-64 using 'lldb a.out -c core'.

[Greg Clayton]

On Jul 16, 2013, at 3:11 PM, Samuel Jacob <samueldotj at gmail.com> wrote:

> I think elf-core patch go in as a separate patch for clarity(1.5K lines). 
> It can go in before or after ProcessMonitor cleanup(9K lines).
> I prefer committing elf-core(if everything compiles and works) before cleanup because I am not sure how long the cleanup would take and dont want elf-core patch to bi rot(again :)).
> 
> What is your opinion on committing elf-core before PosixProcessMonitor cleanup?

That should be fine. I would really like to get this RegisterContext stuff cleaned up so if anyone copies this code for a new Core file type, they have a good base to start with.

Greg

> 
> Thanks
> Samuel
> 
> 
> On Tue, Jul 16, 2013 at 2:43 PM, Greg Clayton <gclayton at apple.com> wrote:
> I spent some time modifying the patch to correctly abstract the register contexts so we don't have this incorrect RegisterContext base class that uses ProcessMonitor... I wasn't able to finish it, but I did get it close. I have attached the patch for you guys to check out and hopefully fix it up and get it working for normal linux/freebsd, and for ELF core files for both linux and freebsd.
> 
> The basics are, the following classes contain the register context data, but don't do any of the reading/writing registers (they have pure virtual functions for that):
> 
> RegisterContextPOSIX_i386
> RegisterContextPOSIX_x86_64
> 
> Then there are classes that inherit from these and each contain grab the process monitor:
> 
> RegisterContextPOSIXProcessMonitor_i386
> RegisterContextPOSIXProcessMonitor_x86_64
> 
> Then there should also be classes that do this for elf:
> 
> RegisterContextELFLinux_XXX
> RegisterContextELFFreeBSD_XXX
> 
> Please try and modify the existing patch to make it work so that we can use ELF core files on all systems.
>