[Lldb-commits] MinGW compilation support

[João Matos]

On Sun, Jul 7, 2013 at 10:44 AM, Virgile Bello <virgile.bello at gmail.com>wrote:

> Here is a patch allowing compilation of LLDB with MinGW.
> (it still compiles on Linux after the patch)
> Can someone please review (and merge in trunk if everything seems good)?
>
> Soon some other patches should follow:
> - 1 for MSVC compilation
> - 1 to add a lldbProcessWindows using Win32 debugging API, so that
> gdb/clang compiled programs can be debugged in Windows.
>
> Hopefully I can get all this into trunk quickly so that I don't need to
> rebase/merge too much.
> Thanks!
>

Just looked at the patch and it mostly LGTM. I think long-term it would be
nice to have the POSIX-specific stuff a little better abstracted, instead
of trying to hack around it in the Windows port, though for now it seems
the way forward and it can be fixed incrementally in the future.

Some questions:

1. Why do we need to define these in "lldb-socket.h"?

+#define NTDDI_VERSION NTDDI_VISTA
+#define _WIN32_WINNT _WIN32_WINNT_VISTA

Can't you just include "lldb-windows.h" which already includes Windows.h?

2. Why are you excluding lldbPluginObjectContainerBSDArchive
and lldbPluginSymbolVendorELF from the MinGW build?

3. Why add support for two build systems (CMake and automake)?

IIRC LLVM and Clang are looking to kill all non-CMake build scripts to ease
maintenance and reduce duplication, so IMHO LLDB being an umbrella project
should do the same.

Apart from that, looking forward to see this getting in and for further
Windows debugging patches.

-- 
João Matos
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130710/0a1dc469/attachment.html>