[Lldb-commits] [lldb] r186020 - Fixed an issue introduced with my last fix where the command and sequence ID extraction were moved causing them to be reversed.

Greg Clayton gclayton at apple.com
Wed Jul 10 10:58:19 PDT 2013


Author: gclayton
Date: Wed Jul 10 12:58:19 2013
New Revision: 186020

URL: http://llvm.org/viewvc/llvm-project?rev=186020&view=rev
Log:
Fixed an issue introduced with my last fix where the command and sequence ID extraction were moved causing them to be reversed.


Modified:
    lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp

Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp?rev=186020&r1=186019&r2=186020&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp (original)
+++ lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp Wed Jul 10 12:58:19 2013
@@ -129,10 +129,10 @@ CommunicationKDP::SendRequestAndGetReply
                 if (WaitForPacketWithTimeoutMicroSecondsNoLock (reply_packet, GetPacketTimeoutInMicroSeconds ()))
                 {
                     offset = 0;
+                    const uint8_t reply_command = reply_packet.GetU8 (&offset);
                     const uint8_t reply_sequence_id = reply_packet.GetU8 (&offset);
                     if (request_sequence_id == reply_sequence_id)
                     {
-                        const uint8_t reply_command = reply_packet.GetU8 (&offset);
                         // The sequent ID was correct, now verify we got the response we were looking for
                         if ((reply_command & eCommandTypeMask) == command)
                         {





More information about the lldb-commits mailing list