[Lldb-commits] [lldb] r184877 - Fix undefined behaviour in data formatter test -- ensure char* null-terminated

Daniel Malea daniel.malea at intel.com
Tue Jun 25 13:54:24 PDT 2013


Author: dmalea
Date: Tue Jun 25 15:54:24 2013
New Revision: 184877

URL: http://llvm.org/viewvc/llvm-project?rev=184877&view=rev
Log:
Fix undefined behaviour in data formatter test -- ensure char* null-terminated
so LLDB does not read off the end of the array.


Modified:
    lldb/trunk/test/functionalities/data-formatter/data-formatter-advanced/main.cpp

Modified: lldb/trunk/test/functionalities/data-formatter/data-formatter-advanced/main.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/data-formatter/data-formatter-advanced/main.cpp?rev=184877&r1=184876&r2=184877&view=diff
==============================================================================
--- lldb/trunk/test/functionalities/data-formatter/data-formatter-advanced/main.cpp (original)
+++ lldb/trunk/test/functionalities/data-formatter/data-formatter-advanced/main.cpp Tue Jun 25 15:54:24 2013
@@ -61,8 +61,11 @@ struct SimpleWithPointers
 	SimpleWithPointers(int X, float Y, char Z) :
 	x(new int (X)),
 	y(new float (Y)),
-	z(new char (Z))
-	{}
+	z(new char[2])
+	{
+          z[0] = Z;
+          z[1] = '\0';
+        }
 };
 
 struct Couple
@@ -168,4 +171,4 @@ int main (int argc, const char * argv[])
     VeryLong a_long_guy;
     
     return 0; // Set break point at this line.
-}
\ No newline at end of file
+}





More information about the lldb-commits mailing list