[Lldb-commits] Patch for Review: Linux split symbol support

[Ed Maste]

On 13 June 2013 17:49, Michael Sartain <mikesart at valvesoftware.com> wrote:
> http://llvm-reviews.chandlerc.com/D960
>
> This patch creates a unified section list in the module which contains
> sections from the object file and possibly sections from the symbol vendor.
> GetSymtab() and other routines have been modified to (potentially) operate
> off that unified section list. Host/linux/Symbols.cpp will search in the
> various Linux-y spots for the split symbol files.

I'm very happy to see that this is being worked on.

I haven't yet reviewed the patch in detail, but as a general comment
this isn't Linux-specific -- it's probably more correct to call it
"ELF-y."  Specifically, it looks like this logic applies wholesale to
FreeBSD, and linux/Symbols.cpp probably belongs in common/ instead.

It seems unusual to dlopen libbfd to obtain a crc32; as far as I can
see it's just a standard implementation.  You can probably grab an
appropriate one from the FreeBSD source tree:
http://svnweb.freebsd.org/base/head/sys/libkern/crc32.c?view=markup

-Ed