[Lldb-commits] [lldb] r182875 - Error out if the expression for a breakpoint

Sean Callanan scallanan at apple.com
Wed May 29 13:22:18 PDT 2013


Author: spyffe
Date: Wed May 29 15:22:18 2013
New Revision: 182875

URL: http://llvm.org/viewvc/llvm-project?rev=182875&view=rev
Log:
Error out if the expression for a breakpoint
condition doesn't return a result, instead
of blindly trying to use that result.

<rdar://problem/14009519>

Modified:
    lldb/trunk/source/Breakpoint/BreakpointLocation.cpp

Modified: lldb/trunk/source/Breakpoint/BreakpointLocation.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Breakpoint/BreakpointLocation.cpp?rev=182875&r1=182874&r2=182875&view=diff
==============================================================================
--- lldb/trunk/source/Breakpoint/BreakpointLocation.cpp (original)
+++ lldb/trunk/source/Breakpoint/BreakpointLocation.cpp Wed May 29 15:22:18 2013
@@ -312,6 +312,12 @@ BreakpointLocation::ConditionSaysStop (E
     
     if (result_code == eExecutionCompleted)
     {
+        if (!result_variable_sp)
+        {
+            ret = false;
+            error.SetErrorString("Expression did not return a result");
+        }
+        
         result_value_sp = result_variable_sp->GetValueObject();
 
         if (result_value_sp)





More information about the lldb-commits mailing list