[Lldb-commits] PATCH for REVIEW: parse ansi color codes for prompt, add use color settings

Mike Sartain mikesart at valvesoftware.com
Thu May 23 13:00:38 PDT 2013

From: Malea, Daniel [daniel.malea at intel.com]
> Hi Mike, this looks promising! I'm having some difficulty applying this patch on the latest trunk though; seeing a conflict in AnsiTerminal.h.
> As an aside, lldb folk don't seem to use this much, but if you have a git workflow, I found LLVM reviews to be pretty painless through the "phabricator" instance that's been set up. If you haven't seen it, check out:

How does this look?


And this is the Linux "platform process list" one...


The UI on chandlerc.com is really slick. So is it best to create a diff there (like the two above) and then send e-mail to the lldb-commits alias for review before checking in?
Thanks Daniel.

More information about the lldb-commits mailing list